palantir / tslint-react

:orange_book: Lint rules related to React & JSX for TSLint.
Apache License 2.0
749 stars 76 forks source link

Prepare release v2.0.0 #37

Closed adidahiya closed 8 years ago

adidahiya commented 8 years ago
adidahiya commented 8 years ago

@nchen63 something's up with the test runner CLI and the build scripts here.

  1. the tslint test runner CLI can't handle test directories with multiple rule options
  2. tslint-react builds should fail on errors like this:
test/rules/jsx-alignment/test.tsx.lint: Passed

/home/ubuntu/tslint-react/node_modules/tslint/lib/configuration.js:113
            throw new Error("Could not find config file at: " + path.resolve(s
                  ^
Error: Could not find config file at: /home/ubuntu/tslint-react/test/rules/jsx-curly-spacing/tslint.json
    at findConfigurationPath (/home/ubuntu/tslint-react/node_modules/tslint/lib/configuration.js:113:19)
    at Function.findConfiguration (/home/ubuntu/tslint-react/node_modules/tslint/lib/configuration.js:89:16)
    at Object.runTest (/home/ubuntu/tslint-react/node_modules/tslint/lib/test.js:32:31)
    at Object.<anonymous> (/home/ubuntu/tslint-react/node_modules/tslint/lib/tslint-cli.js:120:26)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
test/rules/jsx-no-lambda/test.tsx.lint: Passed
test/rules/jsx-no-multiline-js/test.tsx.lint: Passed
test/rules/jsx-no-string-ref/test.tsx.lint: Passed
test/rules/jsx-self-close/test.tsx.lint: Passed
adidahiya commented 8 years ago

For now, I'm going to test this locally and publish 2.0 if it works.

adidahiya commented 8 years ago

confirmed behavior locally