search

palantir / tslint-react

:orange_book: Lint rules related to React & JSX for TSLint.
Apache License 2.0
749 stars 76 forks source link

Development > Quick steps might use global TSLint during rules verification #82

Closed IllusionMH closed 7 years ago

IllusionMH commented 7 years ago

scripts/verify.sh uses tslint executable from PATH and if launched not from npm/yarn script (as shown in Quick steps) will use global TSLint installation.

Possible solutions:

  1. Use tslint executable from node_modules in verify.sh file ./node_modules/.bin/tslint -r ./build/rules/ --test $path/..

  2. Add local installation to path in Quick steps PATH=./node_modules/.bin:$PATH ./scripts/verify.sh

adidahiya commented 7 years ago

Good catch. I prefer option (1)