search

palantir / witchcraft-rust-server

A highly opinionated Rust embedded application server for RESTy APIs
Apache License 2.0
4 stars 7 forks source link

Make Service async fn-compatible #155

Closed sfackler closed 10 months ago

sfackler commented 10 months ago

Before this PR

The Service trait required that the call method's future be nameable and not borrow anything from self. This required lots of Arc cloning and manual future implementations.

After this PR

==COMMIT_MSG== Cleaned up the internal Service trait. ==COMMIT_MSG==

Using the new support added in Rust 1.75 (https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html), we can change Service's signature to allow the call method to be written as a normal async fn.

This significantly simplifies the internal service layers. Manual future implementations are now reserved for low level operations that can't be expressed with async/await.

Unlike https://github.com/palantir/conjure-rust-runtime/pull/176, this doesn't affect the public API.

changelog-app[bot] commented 10 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Cleaned up the internal `Service` trait. **Check the box to generate changelog(s)** - [x] Generate changelog entry