Use PHP 8 - Githubissues

palantirnet / drupal-skeleton

A Drupal project template for use with `composer create-project`.

Other

13 stars 3 forks source link

Use PHP 8 #127

Closed becw closed 2 years ago

becw commented 2 years ago

[x] Use PHP 8.1 on CircleCI
[x] Use PHP 8.1 in ddev
[ ] Is there other code in here that needs updating for PHP 8?

agentrickard commented 2 years ago

Full support for PHP 8 requires Drush 11 (officially) which requires Devel 5, so we should probably account for that.

becw commented 2 years ago

Full support for PHP 8 requires Drush 11 (officially) which requires Devel 5, so we should probably account for that.

Hmm, Composer doesn't enforce this dependency... when I install palantirnet/drupal-skeleton now it installs Drush 11.2.1 and Devel 4.2.1. So this must be like a verbal/documented dependency and not a technical dependency?

becw commented 2 years ago

I found that the only constraint on the Devel version was... our own composer.json file. So I removed the upper bound on that in a separate PR.