search

palash25 / pyphers

Ciphers implemented in python [This is not a serious project. Just an attempt to learn python]
11 stars 5 forks source link

updated hill cipher and added rail fence cipher #14

Closed debck closed 6 years ago

debck commented 6 years ago

@palash25 bhaiya i did some work. Its ok na

palash25 commented 6 years ago

@debck I told you there was no need to close your previous PR. You should have worked on that, fixed the Hill cipher and then made a separate PR for rail-fence cipher. Also, you are making changes from your master branch which is not a good practice. For every change, you should make a new branch and push it as a new PR. Now I'm going to close this PR too. You should make 2 new PRs one for hill and another for rail-fence and before proceeding further please read this guide: https://github.com/p-society/intro-to-open-source-2017 to familiarize yourself with github and the best practices. Also, include the screenshots of the output in your PR descriptions next time you open a new PR because I don't have the time to test your code right now so I would need some visual confirmation before merging. If you still don't understand something feel free to ask on the gitter channel and you can also take a look at other PRs I have merged for reference if you get stuck. Happy hacking :smile: