Closed sibasish14 closed 6 years ago
@sibasish14 This looks good. Just one change though you should remove your name from the file as I think its redundant. If someone opens this file github will automatically show you as the author of this commit so there is no need to write the author's name. Amend your commit and I will merge it.
Also can you update the README.md accordingly
The README change should be a separate commit and should be made after you have amended the previous one and pushed along with this PR. So in the end you will have 2 commits in this PR.
What changes should I make in the README.md file? Include the GeeksforGeeks link for the cipher?(It's in cpp though)
Yeah you can include that link if you want.
Changes done. Please have a look.
@sibasish14 good work :+1:
update the spreadsheet
Should I delete my current branch or keep it for further commits(if any)?
@sibasish14 Yes delete it on your fork and also on your clone every PR need a new branch so since your PR has been merged you don't need this branch anymore. Just keep your fork and clone updated by pulling from upstream.
For updating my clone its - git pull ??
google it or refer to coala's guide
Python implementation of Vigenere Cipher.