palavatv / palava-web

Front-end of palava.tv
https://palava.tv
MIT License
10 stars 4 forks source link

Play a sound when someone connects or disconnects #22

Closed janlelis closed 3 years ago

pascalwengerter commented 4 years ago

Can this be hooked up within Room.vue, e.g. within the rtc.on("peer_joined", [...] function/event (line 142)?

janlelis commented 4 years ago

Exactly. I have already been playing around to record/produce the two sounds, but also looking for suggestions :)

Also, we can iterate on the exact sounds, or run some kind of poll

janlelis commented 4 years ago

Main events:

More interesting events (could be done in a 2nd stop):

pascalwengerter commented 4 years ago

Hey @janlelis, I've just added a proof of concept here.

There's two potential solutions, AFAIK:

  1. Produce a sound the way I've demonstrated
  2. Provide some sound files as assets and play them via JS (the way e.g. Google Meet/Hangouts does this).

My preference is option 2, and I can look into producing two distinct sounds for - as a start - peer_joined and peer_left?

janlelis commented 4 years ago

@pascalwengerter Awesome! I'll take a look early next week!

If it is stable enough web audio would be awesome, maybe option 2 is just a fall-back (on the other hand, we currently only target modern browsers)

janlelis commented 4 years ago

Hey Pascal! Thanks for the proof-of-concept "beep"! Although I Love that it is generated in the browser, I think from a sound-design perspective, there is still some room for improvements :). Maybe we can jam with the sounds on some other web platform (where jamming is easier) and then move it to palava? (We could also do a jam session at my place!)

pascalwengerter commented 4 years ago

@janlelis let's go ahead with this one during our session later this week, looking forward!

pascalwengerter commented 4 years ago

@janlelis I'm back at it - feel free to take a look at this PoC!

pascalwengerter commented 3 years ago

@janlelis this one can be closed after yesterday's merge, right? :)

janlelis commented 3 years ago

@janlelis this one can be closed after yesterday's merge, right? :)

Would love to have it on staging first, @farao have you gotten round rebasing it into the staging branch?

pascalwengerter commented 3 years ago

Would love to have it on staging first, @farao have you gotten round rebasing it into the staging branch?

Ah damn, I had guessed your release triggered some CI/CD thing 😅 my bad!

janlelis commented 3 years ago

Online! (On Staging)