search

palavatv / palava-web

Front-end of palava.tv
https://palava.tv
MIT License
10 stars 4 forks source link

Pass room names in lowerCase to fix #89 #92

Closed pascalwengerter closed 6 months ago

pascalwengerter commented 2 years ago

Potentially fixes https://github.com/palavatv/palava-web/issues/89, not sure if wanted from a product perspective though - as described in the issue it makes some users wonder "why this software doesn't work", but it also kinda increases the possibility for name-clashes of roomIds

janlelis commented 2 years ago

Hey, thanks for the suggestion! I can understand the problem and I think I am slightly in favor of switching to case-insensitve room names. I have one remark / side-node (it's kind of offtopic to this PR, but somewhat relevant):

I have the idea of changing the current auto-generated room names from the UUID-like naming schema to shorter tokens, a little bit like the YouTube IDs. The great thing if we keep the current case-sensitive room IDs would be that the short tokens could be even shorter, because single characters carry more information.

What do all think about this? @farao @KopierKatze @paulgoetze @juwi

pascalwengerter commented 2 years ago

Does anyone has an opinion here? :)

pascalwengerter commented 6 months ago

Closing as not actionable and to be discussed in #123