Add option to start signaltower only on localhost

palavatv / signaltower

Signaling server for WebRTC video-/audio conferencing using the palava protocol

https://palava.tv

GNU General Public License v3.0

39 stars 7 forks source link

Add option to start signaltower only on localhost #15

Closed farao closed 4 years ago

farao commented 4 years ago

Currently the signaltower starts on all network hosts (0.0.0.0 in netstat) and this should stay the default. Nevertheless, an option to start only on localhost, e.g. when the signaltower is begin a reverse proxy like nginx, is needed as a configurable option, e.g. SIGNALTOWER_LOCALHOST=y.

janlelis commented 4 years ago

I think this is a useful feature. Some points that come to my mind:

For some configurations, it might also be useful to bind to a local network address only
Lets discuss, if it would also be a sensible default to bind to localhost, with explicit README examples how to start it on a public ip? This would prevent accidental "open" signaltower instances

erikzenker commented 4 years ago

You can assign the issue to me

erikzenker commented 4 years ago

I provided a pull request #23. We could use the PR to discuss about the issue.

farao commented 4 years ago

Fixed by pr #23