search

palavatv / signaltower

Signaling server for WebRTC video-/audio conferencing using the palava protocol
https://palava.tv
GNU General Public License v3.0
39 stars 7 forks source link

feat: Add SIGNALTOWER_LOCALHOST environment variable to enable listen… #23

Closed erikzenker closed 4 years ago

erikzenker commented 4 years ago

…ing on localhost

erikzenker commented 4 years ago

I think I could also add a build matrix to ci which runs the tests with both listener modes

erikzenker commented 4 years ago 
1. Jan suggested once to make localhost the default to prevent accidentally open instances - what do you think about it?

I think the most probable case should be default. So I would stick to the current behavior. In general, I would provide the endpoint explicit as command line option.

erikzenker commented 4 years ago

Another useful thing, maybe for another pull request, would be to allow custom addresses to bind to, so users are not limited to all or nothing.

Created #29