search

palavatv / signaltower

Signaling server for WebRTC video-/audio conferencing using the palava protocol
https://palava.tv
GNU General Public License v3.0
39 stars 7 forks source link

Auto formatting #3

Closed paulgoetze closed 4 years ago

paulgoetze commented 4 years ago

There is no functional changes in this PR, just a bit of house-keeping.

It adds the configuration and applies mix’s built-in auto-formatting and adds a log file to .gitignore that is created when running tests locally.

farao commented 4 years ago

Generally, a huge improvement. As pointed out, I'm a bit sad about not aligning things (e.g. arrows) anymore and the strange empty lines between e.g. cond cases, but if it makes it easier to have a coherent format then I can accept it

paulgoetze commented 4 years ago

@farao I see where you are coming from in terms of formatting, but I figure that's the reason for why a formatter was added to Elixir in the first place - to not have to argue about it anymore ;) As far as I could see there is no options or customizations of the formatting. Maybe also if it looks weird it can be done in a better/different way...?

I would still stick to the official formatting just for consistency reasons. And it's probably a huge time saver.

farao commented 4 years ago

True! Thanks :-)