search

palavatv / signaltower

Signaling server for WebRTC video-/audio conferencing using the palava protocol
https://palava.tv
GNU General Public License v3.0
39 stars 7 forks source link

feat: Add created/closed room prometheus metric #9

Closed erikzenker closed 4 years ago

erikzenker commented 4 years ago

This PR adds the metrics palava_room_created_total and palava_room_closed_total which we can use to calculate the number of open rooms

farao commented 4 years ago

Please resolve the conflicts that I can merge this

erikzenker commented 4 years ago

@farao master is red. The merge #4 which lead to the current conflict with my branch introduced errors. These errors need to be fixed to get a green master again.

erikzenker commented 4 years ago

Here the link to CI https://github.com/farao/signaltower/runs/627738250?check_suite_focus=true

farao commented 4 years ago

@farao master is red. The merge #4 which lead to the current conflict with my branch introduced errors. These errors need to be fixed to get a green master again.

Sorry, I fixed that. But it also says "This branch has conflicts that must be resolved", I think that's because Paul restructured some things in the meantime...

erikzenker commented 4 years ago

This branch has conflicts that must be resolved

Yes, just wanted to rebase onto a valid master.

erikzenker commented 4 years ago

I fixed that

Thx a lot !