fix(log)!: `Invalid*` exceptions replaced with `CommandError`; errors are logged with the API response

palazzem / econnect-python

API adapter used to control programmatically an Elmo alarm system

BSD 3-Clause "New" or "Revised" License

8 stars 5 forks source link

fix(log)!: `Invalid*` exceptions replaced with `CommandError`; errors are logged with the API response #137

Closed palazzem closed 8 months ago

palazzem commented 8 months ago

Related Issues

Closes #112

Proposed Changes:

Instead of raising multiple exceptions and assuming what the error is, we raise a single CommandError exception when any command fails. Furthermore, we log the actual backend response, if any.

Testing:

n/a

Extra Notes (optional):

n/a

Checklist

[x] Related issues and proposed changes are filled
[x] Tests are defining the correct and expected behavior
[x] Code is well-documented via docstrings

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7745958230

0 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 7745724435:	0.0%
Covered Lines:	374
Relevant Lines:	374