Logging is missing and in some calls is misleading - Githubissues

palazzem / econnect-python

API adapter used to control programmatically an Elmo alarm system

BSD 3-Clause "New" or "Revised" License

8 stars 5 forks source link

Logging is missing and in some calls is misleading #143

Open palazzem opened 4 months ago

palazzem commented 4 months ago

Describe the bug We should improve the DEBUG and ERROR logging as some parts of the library are not covered. Furthermore, in some sections when there is an error the library assumes it's a specific error, misleading the triage. #137 is an example.

Error message Misleading triage.

Expected behavior Exceptions should be meaningful, and full body responses and requests must be logged with obfuscation.

Additional context n/a

To Reproduce n/a

Environment

Operating System (OS): n/a
Library version (commit or version number): n/a
Home Assistant version: n/a
Last working Home Assistant release (if known): n/a

palazzem commented 1 month ago

We can include this change within https://github.com/palazzem/econnect-python/issues/151