Fixed post authentication url and arm/disarm single sector

palazzem / econnect-python

API adapter used to control programmatically an Elmo alarm system

BSD 3-Clause "New" or "Revised" License

8 stars 5 forks source link

Fixed post authentication url and arm/disarm single sector #44

Closed markin closed 4 years ago

markin commented 4 years ago

After authentication apiURL is the right endpoint to query. Parsing of "var apiURL" has been added and baseURL is updated . In addition, the arm_sector and disarm_sector functions have been added to enable alarms on specific sectors.

palazzem commented 4 years ago

Thanks @markin for the contribution! Let me go through the PR so I can leave some comments. Very likely I will ask you to split the PR in multiple PRs, so that we can isolate every single change in a different contribution.

I'll let you know! Thanks again!

palazzem commented 4 years ago

@markin thanks for the contribution! I've split this PR in multiple PRs: #46 #47 #48 #49 Your code is merged upstream, and your commits have been cherry-picked! You are now an official contributor to this project :)

I'll be happy to get more of your suggestions or contributions, so feel free to open a new issue to start a discussion about something, so I can give you some directions before you implement the changes. That will speed-up a lot the review process.

Thanks again! :)