search

palazzem / econnect-python

API adapter used to control programmatically an Elmo alarm system
BSD 3-Clause "New" or "Revised" License
8 stars 5 forks source link

Remove check() API #71

Closed palazzem closed 2 years ago

palazzem commented 2 years ago

Overview

This change removes the client.check() API. The rationale is that this shortcut is considered a duplicate and violates the ElmoClient class responsibility. This class must stay lightweight without any extra logic other than handling the connection and make API calls.

codecov-commenter commented 2 years ago

Codecov Report

Merging #71 (3db524e) into master (50e0303) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          276       271    -5     
=========================================
- Hits           276       271    -5
Impacted Files Coverage Δ
elmo/api/client.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50e0303...3db524e. Read the comment docs.