fix(config): `domain` field is required and pre-filled with `default`

palazzem / ha-econnect-alarm

Home Assistant integration that provides a full-fledged Alarm Panel to control your Elmo/IESS alarm systems.

BSD 3-Clause "New" or "Revised" License

10 stars 5 forks source link

fix(config): `domain` field is required and pre-filled with `default` #129

Closed palazzem closed 4 months ago

palazzem commented 4 months ago

Related Issues

Closes #119

Proposed Changes:

Makes domain required during the installation step, forcing users to insert a value. By default, the field is prefilled with default that should work for all users without a vendor.

Testing:

Install the integration and check the installation page.

Extra Notes (optional):

n/a

Checklist

[x] Related issues and proposed changes are filled
[x] Tests are defining the correct and expected behavior
[x] Code is well-documented via docstrings

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 7744169229

0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.095%

Totals
Change from base Build 7743436821:	0.0%
Covered Lines:	597
Relevant Lines:	629