palazzem / ha-econnect-alarm

Home Assistant integration that provides a full-fledged Alarm Panel to control your Elmo/IESS alarm systems.
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

feat: `lock()` accepts a `userId` param if it's required to complete the login #136

Closed palazzem closed 4 months ago

palazzem commented 4 months ago

Related Issues

Proposed Changes:

This change adds support for all main units that require a userId parameter, such as the ETR128.

When the system is armed and disarmed, the AlarmDevice splits and sends the userId and the code if they are both required by the main unit. The login_without_user_id value from the panel details defines if the unit requires it or not.

In case the userId is not required, that parameter is not sent. If panel details are not available, the device assumes it's not needed (true for most recent main units).

Users can insert both code directly from the alarm panel simply combining first the userId and then the code.

Example:

Testing:

n/a

Extra Notes (optional):

n/a

Checklist

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 7783559573


Totals Coverage Status
Change from base Build 7759757295: 0.2%
Covered Lines: 620
Relevant Lines: 664

💛 - Coveralls