palazzem / ha-econnect-alarm

Home Assistant integration that provides a full-fledged Alarm Panel to control your Elmo/IESS alarm systems.
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Deprecated constant #161

Closed galtamur closed 1 month ago

galtamur commented 1 month ago

Describe the bug When HA starts, the log shows some warning messages for deprecated constants.

Error message XXX was used from econnect_metronet, this is a deprecated constant which will be removed in HA Core 2025.1. Use CodeFormat.NUMBER instead, please report it to the author of the 'econnect_metronet' custom integration

Expected behavior The integration is working but this message is shown in the log.

To Reproduce Just start HA.

Environment

The complete set of messages in the log 2024-05-14 02:43:01.390 WARNING (ImportExecutor_0) [homeassistant.components.alarm_control_panel] FORMAT_NUMBER was used from econnect_metronet, this is a deprecated constant which will be removed in HA Core 2025.1. Use CodeFormat.NUMBER instead, please report it to the author of the 'econnect_metronet' custom integration 2024-05-14 02:43:01.398 WARNING (ImportExecutor_0) [homeassistant.components.alarm_control_panel] FORMAT_NUMBER was used from econnect_metronet, this is a deprecated constant which will be removed in HA Core 2025.1. Use CodeFormat.NUMBER instead, please report it to the author of the 'econnect_metronet' custom integration 2024-05-14 02:43:01.406 WARNING (ImportExecutor_0) [homeassistant.components.alarm_control_panel.const] SUPPORT_ALARM_ARM_AWAY was used from econnect_metronet, this is a deprecated constant which will be removed in HA Core 2025.1. Use AlarmControlPanelEntityFeature.ARM_AWAY instead, please report it to the author of the 'econnect_metronet' custom integration 2024-05-14 02:43:01.416 WARNING (ImportExecutor_0) [homeassistant.components.alarm_control_panel.const] SUPPORT_ALARM_ARM_HOME was used from econnect_metronet, this is a deprecated constant which will be removed in HA Core 2025.1. Use AlarmControlPanelEntityFeature.ARM_HOME instead, please report it to the author of the 'econnect_metronet' custom integration 2024-05-14 02:43:01.425 WARNING (ImportExecutor_0) [homeassistant.components.alarm_control_panel.const] SUPPORT_ALARM_ARM_NIGHT was used from econnect_metronet, this is a deprecated constant which will be removed in HA Core 2025.1. Use AlarmControlPanelEntityFeature.ARM_NIGHT instead, please report it to the author of the 'econnect_metronet' custom integration 2024-05-14 02:43:01.432 WARNING (ImportExecutor_0) [homeassistant.components.alarm_control_panel.const] SUPPORT_ALARM_ARM_VACATION was used from econnect_metronet, this is a deprecated constant which will be removed in HA Core 2025.1. Use AlarmControlPanelEntityFeature.ARM_VACATION instead, please report it to the author of the 'econnect_metronet' custom integration

palazzem commented 1 month ago

Hello @galtamur ! Thanks for filling this issue, I'll be sure to include it in the next release coming this week!

galtamur commented 1 month ago

Great, thank you!

From: Emanuele Palazzetti @.> Sent: 15 May 2024 11:25 To: palazzem/ha-econnect-alarm @.> Cc: galtamur @.>; Mention @.> Subject: Re: [palazzem/ha-econnect-alarm] Deprecated constant (Issue #161)

Hello @galtamur https://github.com/galtamur ! Thanks for filling this issue, I'll be sure to include it in the next release coming this week!

— Reply to this email directly, view it on GitHub https://github.com/palazzem/ha-econnect-alarm/issues/161#issuecomment-2112013798 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APTE4WHU3B4BPDKECISFTHLZCMSVVAVCNFSM6AAAAABHVUELG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGAYTGNZZHA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/APTE4WCF2ISFW7QLAKU3UZLZCMSVVA5CNFSM6AAAAABHVUELG6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT54LC6M.gif Message ID: @. @.> >

palazzem commented 1 month ago

Hello @galtamur ! I took a look and it looks like these deprecation warnings have been already fixed in version 2.3.0 (see https://github.com/palazzem/ha-econnect-alarm/pull/128). Can you try to update your library version from 2.2.1 to 2.3.0?

Theoretically, you should not see any new deprecation, but reach out to me to confirm if the fix works well for you! Thank you very much in advance!

galtamur commented 1 month ago

Hello Emanuele, update done, deprecation warnings disappeared!

Thank you,

GA

From: Emanuele Palazzetti @.> Sent: 15 May 2024 15:13 To: palazzem/ha-econnect-alarm @.> Cc: galtamur @.>; Mention @.> Subject: Re: [palazzem/ha-econnect-alarm] Deprecated constant (Issue #161)

Hello @galtamur https://github.com/galtamur ! I took a look and it looks like these deprecation warnings have been already fixed in version 2.3.0 (see #128 https://github.com/palazzem/ha-econnect-alarm/pull/128 ). Can you try to update your library version from 2.2.1 to 2.3.0?

Theoretically, you should not see any new deprecation, but reach out to me to confirm if the fix works well for you! Thank you very much in advance!

— Reply to this email directly, view it on GitHub https://github.com/palazzem/ha-econnect-alarm/issues/161#issuecomment-2112483616 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APTE4WHLYJ5OT2YG7WSNCYLZCNNOHAVCNFSM6AAAAABHVUELG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGQ4DGNRRGY . You are receiving this because you were mentioned. https://github.com/notifications/beacon/APTE4WHOMAGTVUNYURWZ5CLZCNNOHA5CNFSM6AAAAABHVUELG6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT55HYSA.gif Message ID: @. @.> >

palazzem commented 1 month ago

Great! Feel free to post your feedback any time you see room for improvements! Thanks again!