search

palazzem / ha-econnect-alarm

Home Assistant integration that provides a full-fledged Alarm Panel to control your Elmo/IESS alarm systems.
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Add an official icon #47

Closed palazzem closed 8 months ago

palazzem commented 9 months ago

Is your feature request related to a problem? Please describe.

Currently the integration is not showing any icon. We should provide an icon to represent the e-Connect cloud.

Describe the solution you'd like

Prepare an e-Connect icon and add it to official repository: https://github.com/home-assistant/brands

Describe alternatives you've considered

n/a

Additional context

We should take in consideration that we support also IESS, so we should pay attention to what icon are we adding there.

xtimmy86x commented 9 months ago

For my personal opinion, is good to use the "Elmo" icon because is the Main brand of Elmo and IESS brands below my test icons

icon icon@2x logo logo@2x

palazzem commented 9 months ago

Yeah, I was also thinking to use the e-Connect one, that is not related to a brand but more to the technology.

Example:

image

Actually, it looks like it is the icon used in Alexa / Google Home, so maybe it could be a good option (source: https://www.amazon.it/EL-MO-S-p-A-e-Connect/dp/B07SM9PLZ9)!

xtimmy86x commented 9 months ago

Yeah, I was also thinking to use the e-Connect one, that is not related to a brand but more to the technology.

Example: image

Actually, it looks like it is the icon used in Alexa / Google Home, so maybe it could be a good option (source: https://www.amazon.it/EL-MO-S-p-A-e-Connect/dp/B07SM9PLZ9)!

Is a good idea but for my opinion the integration is called Elmo/IESS alarm so the icon/logo should follow this line

palazzem commented 9 months ago

Cool, let's ask the community over Discord and let's see what they think! that should be a no-brainer to implement after!

palazzem commented 9 months ago

We decided to move forward with the e-Connect icon and then renaming the integration as "e-Connect/Metronet Alarm" (the integration domain will become econnect_metronet_alarm).

xtimmy86x commented 9 months ago

If we use a mixed icon like this?

e-Connect-1

palazzem commented 9 months ago

This would work! We should make it squared and see how it looks like! I can do some tries, or let me know if you want to take over the task!

xtimmy86x commented 9 months ago

econnect-metronet2

With the square form it turns out like this, don't look at the black outline, it's for illustration purposes only

palazzem commented 9 months ago

That looks great! if you want you can share it in the Discord channel and gather further feedback!

xtimmy86x commented 9 months ago

Screenshot 2023-10-01 094743aaa

This is the landscape version of the logo If is ok for you i proceed with the creation of the necessary files

palazzem commented 9 months ago

@xtimmy86x I'd say this is perfect! impressive job! whenever you have time, feel free to share all the assets so I can create the PR in https://github.com/home-assistant/brands (of course I'll tag you to give you credits for this great work!)

palazzem commented 8 months ago

Icons have been published in https://github.com/home-assistant/brands/pull/4750 and the CDN has been reset as planned. This task is now closed, thank you very much @xtimmy86x for the work on the icons!