palazzem / ha-econnect-alarm

Home Assistant integration that provides a full-fledged Alarm Panel to control your Elmo/IESS alarm systems.
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Release workflow doesn't release tar/zip packages. #75

Closed palazzem closed 8 months ago

palazzem commented 8 months ago

Describe the bug

The build system doesn't work and doesn't release the tar/zip packages.

Error message

🤔 Pattern '/home/runner/work/ha-econnect-alarm/ha-econnect-alarm/dist/econnect_metronet-$PKG_VERSION.tar.gz' does not match any files.
🤔 Pattern '/home/runner/work/ha-econnect-alarm/ha-econnect-alarm/dist/econnect_metronet-$PKG_VERSION.zip' does not match any files.

Expected behavior

It must publish both of them.

Additional context

$PKG_VERSION variable is not expanded. We should probably use {{ x }} notation.

To Reproduce

https://github.com/palazzem/ha-econnect-alarm/actions/runs/6482746561/job/17602861706

Environment

CI

palazzem commented 8 months ago

Furthermore, if the release page includes the tar.gz file, it looks like HACS is unable to install the package. These are the relevant logs:

2023-10-13 13:18:29.404 DEBUG (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Getting repository information
2023-10-13 13:18:29.975 DEBUG (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Running checks against v2.0.1
2023-10-13 13:18:31.073 INFO (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Running pre installation steps
2023-10-13 13:18:31.074 INFO (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Pre installation steps completed
2023-10-13 13:18:31.074 INFO (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Running installation steps
2023-10-13 13:18:31.074 DEBUG (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Getting repository information
2023-10-13 13:18:31.824 DEBUG (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Running checks against v2.0.1
2023-10-13 13:18:33.177 DEBUG (SyncWorker_1) [custom_components.hacs] Backup for /config/custom_components/econnect_metronet, created in /tmp/hacs_backup/econnect_metronet
2023-10-13 13:18:33.180 DEBUG (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Local path is set to /config/custom_components/econnect_metronet
2023-10-13 13:18:33.180 DEBUG (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Remote path is set to custom_components/econnect_metronet
2023-10-13 13:18:33.181 DEBUG (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> ref: v2.0.1 --- tag: v2.0.1
2023-10-13 13:18:33.181 DEBUG (MainThread) [custom_components.hacs] <QueueManager> Checking out tasks to execute
2023-10-13 13:18:33.182 DEBUG (MainThread) [custom_components.hacs] <QueueManager> Starting queue execution for 3 tasks
2023-10-13 13:18:33.185 DEBUG (MainThread) [custom_components.hacs] Downloading https://github.com/palazzem/ha-econnect-alarm/releases/download/v2.0.1/econnect_metronet-2.0.1.tar.gz
2023-10-13 13:18:33.188 DEBUG (MainThread) [custom_components.hacs] Downloading https://github.com/palazzem/ha-econnect-alarm/releases/download/v2.0.1/econnect_metronet-2.0.1.zip
2023-10-13 13:18:33.190 DEBUG (MainThread) [custom_components.hacs] Downloading https://github.com/palazzem/ha-econnect-alarm/releases/download/v2.0.1/hacs_econnect_metronet.zip
2023-10-13 13:18:33.883 INFO (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Download of econnect_metronet-2.0.1.zip completed
2023-10-13 13:18:33.885 DEBUG (SyncWorker_0) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Cleaning up /tmp/tmp0a27cv_y
2023-10-13 13:18:34.142 INFO (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Download of hacs_econnect_metronet.zip completed
2023-10-13 13:18:34.144 DEBUG (SyncWorker_9) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Cleaning up /tmp/tmp7x7p0t9w
2023-10-13 13:18:34.147 DEBUG (MainThread) [custom_components.hacs] <QueueManager> Queue execution finished for 3 tasks finished in 0.97 seconds
2023-10-13 13:18:34.148 ERROR (MainThread) [custom_components.hacs] <Integration palazzem/ha-econnect-alarm> Download was not completed
2023-10-13 13:18:34.210 DEBUG (SyncWorker_0) [custom_components.hacs] Restored /config/custom_components/econnect_metronet, from backup /tmp/hacs_backup/econnect_metronet
2023-10-13 13:18:34.217 DEBUG (SyncWorker_2) [custom_components.hacs] Backup dir /tmp/hacs_backup/  cleared

Given that, we're going to remove this build step and only release the HACS .zip file.