search

palday / JellyMe4.jl

RCall support for MixedModels.jl and lme4
MIT License
13 stars 2 forks source link

MixedModels 3.0 compatibility #37

Closed palday closed 3 years ago

palday commented 4 years ago

There is unfortunately a regression in handling || in R with categorical variables because (1|grp) + (0+x|grp) is no longer synonymous with (1|grp) + (fulldummy(x)|grp) on the Julia side as of MixedModels 3.0.

This isn't technically a breaking change; it's just now that we detect this error condition.

Given that this error is in the less-interesting direction, actually providing a fix or work around is very low priority.

codecov[bot] commented 4 years ago

Codecov Report

Merging #37 (78a87ee) into master (85fa2f1) will decrease coverage by 0.62%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   91.98%   91.35%   -0.63%     
==========================================
  Files           6        6              
  Lines         237      243       +6     
==========================================
+ Hits          218      222       +4     
- Misses         19       21       +2
Impacted Files Coverage Δ
src/glmerMod.jl 90.56% <33.33%> (-1.67%) :arrow_down:
src/lmerMod.jl 94.64% <100.00%> (+0.30%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85fa2f1...78a87ee. Read the comment docs.