palday / JellyMe4.jl

RCall support for MixedModels.jl and lme4
MIT License
12 stars 2 forks source link

Update formula.jl to include asinh #67

Closed Tristan-Siegfried closed 1 year ago

Tristan-Siegfried commented 1 year ago

The asinh transformation would be nice to include as it is somewhat commonly used and trivial to add support for: asinh transformation uses parallel syntax in R and Julia, so can treat it like exp and log transformations.

palday commented 1 year ago

@Tristan-Siegfried thanks for your contribution! Would you please:

codecov[bot] commented 1 year ago

Codecov Report

Merging #67 (56819a7) into main (24ef721) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   92.25%   92.28%   +0.02%     
==========================================
  Files           6        6              
  Lines         297      298       +1     
==========================================
+ Hits          274      275       +1     
  Misses         23       23              
Impacted Files Coverage Δ
src/formula.jl 87.93% <100.00%> (+0.21%) :arrow_up:
Tristan-Siegfried commented 1 year ago

I believe these have been done. Regarding the test, if you want something more substantial than just checking the model conversion has succeeded just let me know.

palday commented 1 year ago

Regarding the test, if you want something more substantial than just checking the model conversion has succeeded just let me know.

Nope, that's fine. I'll approve, merge and tag a release as soon as CI passes.

palday commented 1 year ago

@Tristan-Siegfried thanks for the contribution! If all goes well, the new release will be available in about 20 minutes.