search

paldepind / composable.el

Composable text editing for Emacs.
GNU General Public License v3.0
115 stars 9 forks source link

add whole buffer object binding #12

Closed d12frosted closed 8 years ago

d12frosted commented 8 years ago

Just as title says, now there is B binding to operate on whole buffer. In case I missed something, just let me know.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 97.321% when pulling 75674ee615e8b591c2cf94c5c567d05d05437d84 on d12frosted:features/mark-whole-buffer into 3217f3dc7fc106d952360c77156fac39aa5849e1 on paldepind:master.

paldepind commented 8 years ago

Really great :+1: I've been thinking about this myself.

I'm not sure about the binding though. B requires a modifier, and there are still many keys available that does not. I can see that it has mnemonic value. But I'm thinking that using something that is easier to press might be better. For instance u for buffer. What do you think?

d12frosted commented 8 years ago

Ya, was thinking about the same. Already using B and doesn't quite like it. But I do like u for that. Pretty mnemonic. Would you like me to update key binding or will you do it?

paldepind commented 8 years ago

Please update it and then I'll merge it in :smile:

This is also consistent with y for symbol.

d12frosted commented 8 years ago

Please update it and then I'll merge it in :smile:

Done.

This is also consistent with y for symbol.

Indeed.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 97.321% when pulling d6df86abbee76715658fdbec6e689dc3865f4688 on d12frosted:features/mark-whole-buffer into 3217f3dc7fc106d952360c77156fac39aa5849e1 on paldepind:master.

paldepind commented 8 years ago

Splendid. Thank you for this contribution.

d12frosted commented 8 years ago

You're welcome :)

Thank you for this package :)

~ d12frosted

On Wed, May 4, 2016 at 8:14 PM, Simon Friis Vindum <notifications@github.com

wrote:

Merged #12 https://github.com/paldepind/composable.el/pull/12.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/paldepind/composable.el/pull/12#event-650501234