paleobot / pbot-client

0 stars 0 forks source link

Empty Specimens in OTUs #41

Open NoisyFlowers opened 3 months ago

NoisyFlowers commented 3 months ago

If a public OTU has holotype/type/identified specimens that are not public, there will be entries for those specimens in what is returned for holotype/type/identified. However, those entries will have Specimen: null. This can cause grief in later logic. Need to filter these values out when appropriate.

Why this happens has to do with the group visibility hacks we've implemented in the neo4j-graphql-js package we use in the api server.

NoisyFlowers commented 3 months ago

Filtering of these empty Specimens added to OTUs.js in 8551bad97fba48c5fcc8c3a2065e094eae3739e9

on ddm-dev and running nowhere