search

paleobot / pbot-dev

Codebase and initial design documents for pbot client
MIT License
2 stars 2 forks source link

Public vs. private groups #118

Closed clairecleveland closed 1 year ago

clairecleveland commented 1 year ago

Right now Public is listed as an option inside the Group Selection drop down box when adding/editing a group. Should we just remove Public from drop down list. Is is true that once a group goes public the group is no longer valid? Is there a reason researchers would want to keep a group/project live on their workbench once that information has gone public?

Doug to investigate and provide current status to Botany group.

doricon commented 1 year ago

I just wrote a note in the existing issue for groups/public: https://github.com/paleobot/pbot-dev/issues/94#issuecomment-1614892875 Basically, having 'public' in the dropdown list for groups is critical for being able to search for data in either private groups AND the public data. I had to do this yesterday to find an OTU I made!

aazaff commented 1 year ago

Let's go over this again with screen-share during our Wednesday 7/5 meeting. I think there maybe be 2 or more fixes that need to be clarified related to this.

ecurrano commented 1 year ago

I will be gone this Wednesday (7/5), but leave things in Dori's and Claire's capable hands.

aazaff commented 1 year ago

Okay, we clarified.

The issue, for now, is just that we need to remove "public" as a select option from any Form with a Group Selection picklist since public is a special case that is generally set by a checkbox.

doricon commented 1 year ago

As a clarification to Andrew's clarification - remove "public" from the Groups selection dropdown list in all forms in the Workbench, but leave it as a multiselect option in the Explore search forms dropdowns. :)

NoisyFlowers commented 1 year ago

This is in paleobot/pbot-client@da87b0dedde5090a7f1200e76d0b77b511f482c1