paleobot / pbot-dev

Codebase and initial design documents for pbot client
MIT License
2 stars 2 forks source link

Person search in reference not working #179

Closed ecurrano closed 11 months ago

ecurrano commented 11 months ago

I am trying to add authors to a reference. When I click the magnifying glass to search for people nodes, I am not getting search results for people I recently entered. For example, when searching by surname, I can find Andrew Flynn, but I cannot find William C Clyde.

Let me know if you need more information on this.

ecurrano commented 11 months ago

I also had this issue when trying to search for a person in the people node.

NoisyFlowers commented 11 months ago

To be clear: you're saying that you enter a person, then, when you try to add another, you are not seeing that previous person in the list of people you can select from. Is this correct?

If so, that is by design. This is how the client-side logic prevents duplicate authors/people.

ecurrano commented 11 months ago

No. For example, I entered William C Clyde today. I want to add him as an author on a Journal Article. I can see him on the dropdown menu, but if I try hitting the magnifying glass and searching under surname Clyde (or given name William), I get no results. In contrast, if I search given name for Andrew, I get Andrew Flynn and two Andrew Zaffos.

The same problem occurs when I am in explore and searching person nodes for William or Clyde.

aazaff commented 11 months ago

I think I follow, but just for clarity can you include screenshots.

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: Ellen @.> Sent: Wednesday, August 2, 2023 3:57 PM To: @.> Cc: Zaffos, Andrew - @.>; @.> Subject: [EXT]Re: [paleobot/pbot-dev] Person search in reference not working (Issue #179)

External Email

No. For example, I entered William C Clyde today. I want to add him as an author on a Journal Article. I can see him on the dropdown menu, but if I try hitting the magnifying glass and searching under surname Clyde (or given name William), I get no results. In contrast, if I search given name for Andrew, I get Andrew Flynn and two Andrew Zaffos.

The same problem occurs when I am in explore and searching person nodes for William or Clyde.

— Reply to this email directly, view it on GitHubhttps://github.com/paleobot/pbot-dev/issues/179#issuecomment-1663073680, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACPQSQ5MX3TH5LOJX5HY5GDXTLLMBANCNFSM6AAAAAA3BXWHKQ. You are receiving this because you were assigned.Message ID: @.***>

ecurrano commented 11 months ago

I'm entering a reference:

Screen Shot 2023-08-02 at 5 14 07 PM

I try to search for Clyde:

Screen Shot 2023-08-02 at 5 14 18 PM

My results:

Screen Shot 2023-08-02 at 5 14 25 PM
ecurrano commented 11 months ago

And here's the dropdown menu showing that William C Clyde is there

Screen Shot 2023-08-02 at 5 15 57 PM
ecurrano commented 11 months ago

If I search for Andrew instead:

Screen Shot 2023-08-02 at 5 16 44 PM

I get this result:

Screen Shot 2023-08-02 at 5 16 50 PM
ecurrano commented 11 months ago

And here's what I got when I searched for Clyde (same as in search above) in Explore:

Screen Shot 2023-08-02 at 5 17 41 PM
NoisyFlowers commented 11 months ago

Poor Mr. Clyde was created without a Group.

Person nodes are supposed to be created automatically as public. I've corrected the logic failed Mr. Clyde. This is in: paleobot/pbot-api@e846cf097e68bbc057d31a978dafdfb39054d5c4 paleobot/pbot-client@3b19b9e6b5f24f507486a3f61f938d79813a8d24

I also manually added Mr. Clyde to public.

Please close if it works for you

ecurrano commented 11 months ago

Works for Mr. Clyde. Could you please also fix: Robert Buchwaldt, Esther RS Pinheiro, and Ian M Miller. @doricon also added some new people today that will need to be fixed.

NoisyFlowers commented 11 months ago

I've created MEMBER_OF relationships to public for all Person nodes that were not already.

doricon commented 11 months ago

Fabulous, mine work too now. I am closing this.