search

paleobot / pbot-dev

Codebase and initial design documents for pbot client
MIT License
2 stars 2 forks source link

Edit Specimen Parts Preserved/Preservation Mode: Can not add/delete additional/extra states--Error returned #180

Closed clairecleveland closed 1 year ago

clairecleveland commented 1 year ago

I tried delete Cuticle from Specimen: Hack-A-Thon Specimen 230808.CC.2 and got error message below. Also, tried to add Body to Parts Preserved and got same message.

Error: Cannot read properties of undefined (reading 'includes')

ecurrano commented 1 year ago

I also got a WEIRD error message when I tried to edit a collection. I got this when I was removing a preservation mode, when trying to change the Collection type, or when I tried to edit text in a notes field. Screen Shot 2023-08-02 at 2 00 14 PM

clairecleveland commented 1 year ago

Actually, we can not edit anything on specimen node.

ecurrano commented 1 year ago

I discovered that my specific problem with the collection edit is that I had quotation marks in the notes fields. We do need to be able to use these in notes so that people can add quotes directly from the publication.

NoisyFlowers commented 1 year ago

One problem per issue, please.

NoisyFlowers commented 1 year ago

When we changed Specimen to inherit group from Collection, I overlooked some logic in the api server that expected a groups param from the client.

This is fixed in paleobot/pbot-api@07ee6ffbb51fcf0e83eb41d4b1b9138a4b79e2e6

clairecleveland commented 1 year ago

Thank you Doug!

On Wed, Aug 2, 2023 at 7:42 PM NoisyFlowers @.***> wrote:

Closed #180 https://github.com/paleobot/pbot-dev/issues/180 as completed.

— Reply to this email directly, view it on GitHub https://github.com/paleobot/pbot-dev/issues/180#event-9993178885, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLULEDW2V4ZLBLP3XDJSNTXTLQXZANCNFSM6AAAAAA3BYFXKI . You are receiving this because you were assigned.Message ID: @.***>