search

paleobot / pbot-dev

Codebase and initial design documents for pbot client
MIT License
2 stars 2 forks source link

Reference: Add Journal Article does not flag empty Volume field as required when hit submit #190

Open clairecleveland opened 1 year ago

clairecleveland commented 1 year ago

If the Volume field is left blank and you try to submit, it just hangs. There is no warning that the Volume field is required to submit the Reference. Not sure if this is an issue for all of the other reference types as well.

clairecleveland commented 1 year ago

Need to test to find all of these per PBot A-team comments.

NoisyFlowers commented 8 months ago

I am not able to reproduce this problem. Leaving Volume blank and hitting Submit results in the message "publicationVolume is a required field".

(note: This message should be replaced with "Volume is a required field." Working on that now.)

NoisyFlowers commented 8 months ago

Messages tidied up in paleobot/pbot-client@9158de3235264c25c94701c22efd9ef7e5e01a75.

In master and deployed to stage (prod).

ecurrano commented 8 months ago

I went through and tested all of the reference fields to see where there were any hang-ups or if it was possible to submit without a required field. Everything seems to be ok to me except:

  1. You can submit a contributed article in an edited book without a chapter title. I managed to create null, 2020 (PBot ID: e89c12f2-37d3-43be-bbe3-10eba7a186fd). NOTE- DELETE THIS once this issue is fixed.

There is also some inconsistency in capitalization of the error messages, see attached screenshot for example. Similar to the "publicationVolume" mentioned above. Screen Shot 2024-02-02 at 9 29 46 AM

aazaff commented 8 months ago

Don’t forget you can test using the old site, which is safer.

From: Ellen Currano @.> Date: Friday, February 2, 2024 at 9:31 AM To: paleobot/pbot-dev @.> Cc: Zaffos, Andrew - (azaffos) @.>, Assign @.> Subject: [EXT]Re: [paleobot/pbot-dev] Reference: Add Journal Article does not flag empty Volume field as required when hit submit (Issue #190)

External Email

I went through and tested all of the reference fields to see where there were any hang-ups or if it was possible to submit without a required field. Everything seems to be ok to me except:

  1. You can submit a contributed article in an edited book without a chapter title. I managed to create null, 2020 (PBot ID: e89c12f2-37d3-43be-bbe3-10eba7a186fd). NOTE- DELETE THIS once this issue is fixed.

There is also some inconsistency in capitalization of the error messages, see attached screenshot for example. Similar to the "publicationVolume" mentioned above. Screen.Shot.2024-02-02.at.9.29.46.AM.png (view on web)https://github.com/paleobot/pbot-dev/assets/72828382/cec79ea3-4911-4b4a-b628-e76fb3c9fcf7

— Reply to this email directly, view it on GitHubhttps://github.com/paleobot/pbot-dev/issues/190#issuecomment-1924219502, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACPQSQ4E5JJXIPSMCIV7IQTYRUIHBAVCNFSM6AAAAAA3JLST7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGIYTSNJQGI. You are receiving this because you were assigned.Message ID: @.***>

ecurrano commented 8 months ago

Great point! I will change my testing ways... Does the old site also get updated as Doug does his awesomeness?

aazaff commented 8 months ago

That content of the database will be different, but all the functionality/code should be the same.

ecurrano commented 8 months ago

Cool. I'll move back to the old database to do testing.

ecurrano commented 8 months ago

Although I will am also starting a push to enter real data while doing some testing and will do that in the real site.

NoisyFlowers commented 8 months ago

Ellen, all those problems were dealt with yesterday. You must have been on a browser-cached version of the page. Make sure you do a hard refresh of the browser page.

Regarding the dev machine, it is should automatically update with changes to the master branch. However, I have not been able to access it via browser consistently. http://128.196.196.17/, right? It does not always respond. No idea why.

ecurrano commented 8 months ago

Oh my! I was using a browser cached page. It's a whole new experience today, including green for the workbench heading and gray for explore. Awesome! And the error messages all look great now. And you need to have a title. My null reference also seems to have been deleted.

ecurrano commented 8 months ago

Oh, wait. I still see "null, 2020" in the list of references, and I can't delete it. I was able to delete one of my own unpublished references that didn't have anything in it, though. Perhaps I will just go back and edit it into something I'd like to keep.

aazaff commented 8 months ago

I'm seeing the same connection problem. I'm going to try a simple server restart...