search

paleobot / pbot-dev

Codebase and initial design documents for pbot client
MIT License
2 stars 2 forks source link

Change State Name "quantity" to allow specific name for that state #252

Closed clairecleveland closed 7 months ago

clairecleveland commented 11 months ago

Because the name of quantity states defaults to "quantity" instead of allowing a specific name, it is not possible to have two quantity states listed under a single character. The second entry is rejected because the State "quantity" already exists for that Character. This will become a problem for at least two of the upcoming schemas that include characters such as stomatal dimensions which will include quantities length, width, area, perimeter, etc. Is this a difficult fix that has to be shifted to V2 or is this not such a difficult fix?

aazaff commented 11 months ago

It is not a difficult fix and does not need to wait to V2, but has to wait until pbot dev work resumes in winter.

aazaff commented 8 months ago

I think @NoisyFlowers had a cogent workaround for this but that wasn't recorded in the issue. I'll try to find it later.

NoisyFlowers commented 7 months ago

The proper way to handle the scenario described is to have a stateless super-character "stomatal dimensions" with separate sub-characters for "stomatal length", "stomatal width", etc.