paleobot / pbot-dev

Codebase and initial design documents for pbot client
MIT License
2 stars 2 forks source link

PBot Explore: Collection Search #283

Open ecurrano opened 3 months ago

ecurrano commented 3 months ago

Here is how we would like the PBot Explore Collection Search to look. Note this one is more complicated as there will be accordions, and cross-searches are also required (e.g., we want to be able to search for all collections that contain a given OTU). A star indicates the accordion header, and a dash indicates the searches in that accordion. Anything in brackets indicates where the particular search field exists or additional clarifications and should not be seen by users.

Search by Collection name [fuzzy search]

*Search by Taxonomy

*Search by Fossil Characteristics

*Search by Time

*Search by Location

*Search by Stratigraphy

*Search by Metadata

ecurrano commented 3 months ago

Linking to #279 as it might be complicated to get search by time fields to yield true results.

NoisyFlowers commented 1 month ago

Are we sure we don't want to keep search by specimen?

Also, I think we should keep PBot ID (currently Collection ID). Just move it to Search by Metadata

ecurrano commented 1 month ago

Yes on PBot ID under Search by Metadata.

Also, yes on the search by specimen- that makes good sense that someone might have a specimen number and want to know all the information about the collection. I am ambivalent about where to put this. Maybe under Collection name and not in a dropdown, as it doesn't really fit into any of the dropdowns? @doricon , @clairecleveland : any thoughts?

NoisyFlowers commented 1 month ago

Some of this is in paleobot/pbot-client@11e357967648d838c4a335437e543200eebc7a80 paleobot/pbot-client@4bb7f8053b0ad73e0dcd594a4e485e2996b72f74

merged to master and running on dev.

Complex queries are stubbed. I've retained some things I thought could be valuable.

clairecleveland commented 1 month ago

Hello Ellen,

I'm looking at this now. Did you get my email with the PBot Update email? Should we talk about that today after meeting with Doug and Andrew?

Cheers, Claire

On Tue, May 21, 2024 at 1:26 PM Ellen Currano @.***> wrote:

Yes on PBot ID under Search by Metadata.

Also, yes on the search by specimen- that makes good sense that someone might have a specimen number and want to know all the information about the collection. I am ambivalent about where to put this. Maybe under Collection name and not in a dropdown, as it doesn't really fit into any of the dropdowns? @doricon https://github.com/doricon , @clairecleveland https://github.com/clairecleveland : any thoughts?

— Reply to this email directly, view it on GitHub https://github.com/paleobot/pbot-dev/issues/283#issuecomment-2123101292, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLULEDYUB3PX7COYBMXKELZDN7THAVCNFSM6AAAAABEIB2K3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTGEYDCMRZGI . You are receiving this because you were mentioned.Message ID: @.***>

clairecleveland commented 1 month ago

@ecurrano It looks like Doug created a new accordion for specimen. I think this is appropriate and I like its placement above metadata but toward the end of the list. It's still easy to find even on a smaller device.

NoisyFlowers commented 1 month ago

Taxonomy search is in paleobot/pbot-client@a5b190c3ffd9c591cac8625964212901f752a524 paleobot/pbot-client@a878343b08ee33641dcdc5f49062fe54d923ab50

merged to master and running on dev

NoisyFlowers commented 1 month ago

Location (lat/lon) search is in https://github.com/paleobot/pbot-api/commit/652479b8a184ba3ba1a6b66e56dc413c58c874a8 https://github.com/paleobot/pbot-client/commit/1e362dc9dd9d57d4ac6bb18fbb2d0c4a304ccf71 https://github.com/paleobot/pbot-client/commit/dc09931443d71efcf4a0979c95ff72235679552d

Merged to master and running on dev.

Note 1: To create the required location property in the Collection nodes, this cypher was run before turning this loose:

match (c:Collection  )  
set
    c.location = Point({latitude: c.lat, longitude: c.lon})
return c

Note 2: The api changes were made in a way that should maintain continuity with the previous. In other words, you can access the deprecated lat and lon properties as well as the new location.latitude/location.longitude The lat and lon properties accessed through the api are generated on the fly from those inside location.

Note 3: Ideally, we would also delete the old lat and lon properties in the nodes. I'm leaving them around for now in case there are any latent problems with the conversion cypher in note 1. However, they are no longer accessible through the api (see note 2).

Note: 4: The search radius is currently set to 1500 meters. Let me know if we want it bigger/smaller.

NoisyFlowers commented 1 month ago

Lat/lon search radius changed to 10000 meters in paleobot/pbot-client@5c6a6aea7129c7a3bc434f518c06dcea7a07a75d

merged to master and running on dev

ecurrano commented 1 month ago

A township is 6mi x 6mi, and so the 10km radius will allow for placement within a township (if all you have is township/range information). Ellen needs to look into protected fossil locality information to make sure that these would fall within the search.

NoisyFlowers commented 1 week ago

Parts Preserved and Notable Features search of member Specimens is in paleobot/pbot-client@03faa01a8bf7c96696e40b817484774916d15545

merged to master and running on dev.

This completes all the changes described above except numerical time search. We might consider tracking that one on its own issue.