paleobot / pbot-dev

Codebase and initial design documents for pbot client
MIT License
2 stars 2 forks source link

Cycle through every form where order is possible and implement ordering #93

Closed aazaff closed 1 year ago

aazaff commented 1 year ago

Everywhere where we track order, then that information should be ordered correctly in returns. This is separate from #80 which is a specific bug.

aazaff commented 1 year ago

Based on @clairecleveland's previous desire for certain types of ordering in the form, we think that the data entry process should now include explicitly numbering hierarchy in the sense of - e.g., 1.1.1, 1.2.1, 1.3.8 etc.

aazaff commented 1 year ago

I believe this is also now implemented can we close? @NoisyFlowers

NoisyFlowers commented 1 year ago

I've added ordering via graphql everywhere I could find for Reference and Person (author) nodes. This is in commit paleobot/pbot-client@4b4da71e872c760c54258a70a539b4ad4984cfdc

CharacterInstance, Character, and State ordering will require sorting on the client side rather than through the graphql query. I'm leaving this open until I can get to that.

NoisyFlowers commented 1 year ago

In reviewing the code for displaying CharacterInstances, Characters, and States in both the query results and in mutation forms, I think we are handing order properly.

I'm closing this issue.