paleobot / pbot-static

Static content for pbot client
0 stars 0 forks source link

Our team images #2

Open ecurrano opened 8 months ago

ecurrano commented 8 months ago

I have almost got the "Our Team" page figured out, but am running into a problem I can't easily solve using google. I've figured out how to have our small photographs to the left and then our names and titles next to the image and centered. It looks great if all the text fits on one line, but if it does not, then the second line of text is under the picture rather than directly under the first line of text. Help, please!

I assigned people cause I wasn't sure this would be seen otherwise.

NoisyFlowers commented 3 months ago

I don't see this happening in the current code. I assume you've shortened the lines to make it less likely.

There is another problem with putting the text to the right of the image. For some reason, the markdown handler we use (https://www.npmjs.com/package/markdown-to-jsx) gets confused when there is link markdown immediately following an html img tag and presents the raw markdown text rather than the link. To get it to work right, I had to put a span tag around the link markdown, which just feels wrong but whatever. We're crossing all kinds of abstraction boundaries here (jsx/html/markdown), I suppose it's inevitable that there will be some weirdness.

It looks ok to me right now. But we might consider putting the text below the image rather than next to it. This would make the raw code a little cleaner and avoid problems with longer text later.