paleolimbot / geos

Open Source Geometry Engine ('GEOS') R API
https://paleolimbot.github.io/geos/
Other
61 stars 8 forks source link

Authorship #23

Closed paleolimbot closed 4 years ago

paleolimbot commented 4 years ago

@edzer - This package is essentially a reorganization of your geos.cpp in sf, which I consulted almost constantly while writing this. I'd say this qualifies you as an author if you're up for it! Still needs some tire kicking to make sure my C code isn't going to segfault elsewhere and the documentation is a bit of a mess, but it's essentially done at the moment (no more GEOS functions to implement!). Note the full sf support (currently through WKB, but I could make a dedicated reader much like the geos_make_*() functions).

I'm aware that this overlaps a lot with sf, but the dependency scheme makes it a bit easier to do some of the more niche non-spatial things that implementing in sf would add a lot of unnecessary maintenance burden (e.g., the minimum bounding circle or minimum rotated rectangle or using an strtree to find the nearest feature based on frechet distance). Happy to chat about any of it!

edzer commented 4 years ago

I'd be honored!