paleolimbot / ggspatial

Enhancing spatial visualization in ggplot2
https://paleolimbot.github.io/ggspatial
368 stars 35 forks source link

Add support for terra package #92

Closed dieghernan closed 2 years ago

dieghernan commented 2 years ago

Closes #91

This PR adds specific methods for "SpatRaster" objects created with the terra package. Additionally:

ping @rhijmans

codecov-commenter commented 2 years ago

Codecov Report

Merging #92 (b814c2a) into master (162df0f) will increase coverage by 1.02%. The diff coverage is 79.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   81.87%   82.89%   +1.02%     
==========================================
  Files          19       21       +2     
  Lines        1131     1298     +167     
==========================================
+ Hits          926     1076     +150     
- Misses        205      222      +17     
Impacted Files Coverage Δ
R/layer-spatial-stars.R 0.00% <0.00%> (ø)
R/layer-spatial.R 100.00% <ø> (ø)
R/layer-spatial-terra.R 90.17% <90.17%> (ø)
R/annotation-map-tile.R 100.00% <100.00%> (ø)
R/annotation-north-arrow.R 100.00% <100.00%> (ø)
R/df-spatial-raster.R 100.00% <100.00%> (ø)
R/df-spatial-sf.R 86.36% <100.00%> (ø)
R/df-spatial-terra.R 100.00% <100.00%> (ø)
R/layer-spatial-raster.R 70.86% <100.00%> (+9.05%) :arrow_up:
R/longlake-data.R 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44ff7c9...b814c2a. Read the comment docs.

dieghernan commented 2 years ago

Hi @paleolimbot ,

I am sure you are already aware, but the error is due to some resources not available on RSPM. I changed the tests so they don't use RSPM any more.

See here the latests results on my repo: https://github.com/dieghernan/ggspatial/actions/workflows/R-CMD-check.yaml

paleolimbot commented 2 years ago

Thank you! Sorry for the delay...I wanted to make sure I spent the time to walk through the examples.