paleolimbot / mudata2

Interchange Tools for Multi-Parameter Spatiotemporal Data
https://paleolimbot.github.io/mudata2
27 stars 4 forks source link

Fixes for readr 1.2.0 #31

Closed jimhester closed 6 years ago

jimhester commented 6 years ago

The deparsing commit is just a quality of life improvement I noticed when debugging the test failure with readr 1.2.0.

readr 1.2.0 now errors when the parse functions are used with non-character input. This has always been unexpected input, but previously it would not be an error.

This change simply coerces the vectors to character before passing to the parse functions.

I plan to release readr 1.2.0 to CRAN soon, you will need to release mudata2 as well after it is accepted to avoid test failures on CRAN.

paleolimbot commented 6 years ago

Brilliant! Thank you! Will get this re-released sometime in the next week. Cheers!

jimhester commented 6 years ago

readr 1.2.0 is on CRAN now.