Solving issue #35 - Githubissues

paleolimbot / rbbt

R Interface to the Better BiBTex Zotero Connector

142 stars 25 forks source link

Solving issue #35 #41

Closed LuisLauM closed 11 months ago

LuisLauM commented 1 year ago

Solving issue #35 applying the solution https://github.com/paleolimbot/rbbt/issues/35#issuecomment-1547770626

paleolimbot commented 1 year ago

Thank you and sorry for taking so long to review!

I think that to pass CMD check this will need:

Add #' @param include.chunks Use TRUE to include citations in code chunks to the documentation for bbt_detect_citations().
Running devtools::document() when this project is open in RStudio

Technically include_chunks would be more consistent with current argument names than include.chunks; however, I'm happy to have this feature added either way!

bwiernik commented 1 year ago

@paleolimbot I can clean this up and merge if you like. I have some time today or this week.

paleolimbot commented 1 year ago

That would be great! It sounds like it would solve problems for quite a few people!

dmi3kno commented 1 year ago

I suggest we do it via options(), so that users would be able to adjust it. I am pushing a PR in few minutes. Let's take these two issues separately (in two different PRs)

bwiernik commented 1 year ago

@paleolimbot Can you add me as a collaborator again so I can merge this commit?

paleolimbot commented 1 year ago

Done!

bwiernik commented 12 months ago

@paleolimbot Sorry, apparently my internet connection wasn't working when I accepted the invitation and it didn't go through. Could you resend the collaboration invite? I've got the bugs in this PR all fixed.

dmi3kno commented 11 months ago

If you decide to merge this instead of #42 could you, please add more prefixes, other than just ^fig- and ^tbl-? I would ideally want a pair of eyes to look at my alternative implementation and critique it (#42).

bwiernik commented 11 months ago

@paleolimbot just bumping this

LuisLauM commented 11 months ago

@paleolimbot just bumping this

Oh, I am sorry. I did not realize that the changes on my fork will be taking into account here. I just have been using the original code of @paleolimbot but introducing some features that works for me. Again, my apologizes, I will remove this thread.