Closed anthonynorth closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
e3d4efb
) 99.03% compared to head (ca53871
) 99.03%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Is it worth exposing the "convert to hex" in any other way? It is probably useful in other contexts as well...maybe
wkb_to_hex()
or something?
It could be useful. I can add wkb_to_hex
to this PR, or a separate PR if you'd like me to do it.
Should 2 identical features with different endianness be considered equal? Should vctrs::vec_order(wkb)
be endian-dependent (which it currently is)?
# remotes::install_github("paleolimbot/wk#183")
library(wk)
points <- wkt(c("POINT (1 1)", "POINT (2 2)"))
points_le <- wk_handle(points, wkb_writer(endian = 1))
points_be <- wk_handle(points, wkb_writer(endian = 0))
vctrs::vec_equal(points_le, points_be)
#> [1] FALSE FALSE
vctrs::vec_order(points_le) == vctrs::vec_order(points_be)
#> [1] FALSE FALSE
Created on 2023-07-11 with reprex v2.0.2
I've exported wkb_to_hex()
-- but I haven't rebuilt package documentation.
Thanks! (FWIW, it's usually good practice to rebuild the documentation yourself)
Adds
vctrs::vec_equal()
support forwk_wkb
vectors.Closes #181