search

paleozogt / MSVCDocker

MSVC via Wine in Docker
122 stars 21 forks source link

fix 'bad URI' due to spaces in box file name #16

Open Javanater opened 4 years ago

paleozogt commented 4 years ago

@Javanater I'm not sure what this is supposed to fix. The box file really does have spaces in it.

For example, if I download the box zip manually you can see the space:

➜  wget https://az792536.vo.msecnd.net/vms/VMBuild_20190311/Vagrant/MSEdge/MSEdge.Win10.Vagrant.zip
   ...
➜  unzip -l MSEdge.Win10.Vagrant.zip
Archive:  MSEdge.Win10.Vagrant.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
7189641882  2019-03-19 12:53   MSEdge - Win10.box
---------                     -------
7189641882                     1 file
Javanater commented 4 years ago

@paleozogt, yes I see the space too. When I run make msvc14, I get a 'bad uri' error when the 'vagrant box add --force "$box_file" --name "$box_file"' command is executed. This is fixed by removing the spaces in the box file name. I see now that I did not add a line to rename the file once it is downloaded.