search

paleozogt / MSVCDocker

MSVC via Wine in Docker
121 stars 20 forks source link

Support for msvc 16 (Visual Studio 2019) #3

Closed fzwoch closed 4 years ago

fzwoch commented 5 years ago

I wonder if its "easy" to add support for msvc 16? It wasn't sure what I have to do to add this target to the tool-chain.

paleozogt commented 5 years ago

If you're up for submitting a patch, I can give you some pointers. (I may not be able to get around to it as quickly as I'd like.)

Here's what you need to do:

That last step is the hard part. You'll have to figure out if msvc 16 is available from the chocolatey package manager (if possible, try to use "build tools" and not the full MSVC IDE installation). Then you'll need to get the paths to the vcvars batch files. It might have its own installation quirks to workaround (I'm looking at you, msvc 15).

The build is modularized, so you should be able to test just the vagrant part alone by running make snapshot16. Or once you have the snapshot made, you can build just the docker part with make buildimage16.

When just getting started, I find its simpler to just spin up a fresh image (make setupbasebox), open up the Windows gui, and try stuff manually in a PowerShell window. Then once I know how the installation works, I can bring the PowerShell code over to setup_msvc.ps1.

paleozogt commented 4 years ago

I've brought your changes over to master. Thanks!