palerdot / react-d3-speedometer

React Speedometer component using d3.js ⚛️
https://palerdot.in/react-d3-speedometer/
MIT License
230 stars 57 forks source link

Adding New props #153

Open palerdot opened 1 year ago

palerdot commented 1 year ago

Adding a new prop requires some involved changes and writing tests. I have outlined steps to add a new prop below.

Steps for adding prop

Adding tests:

Please make sure to add a new test to verify the new changes. Example tests can be referred here - https://github.com/palerdot/react-d3-speedometer/blob/master/src/tests/index.js#L88. Also, refer to enzyme documentation.

Important:

Miscellaneous:

Please allow edits from maintainers option for me to update docs if PR is in an acceptable state. Please refer - https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork