search

palerdot / react-d3-speedometer

React Speedometer component using d3.js ⚛️
https://palerdot.in/react-d3-speedometer/
MIT License
230 stars 57 forks source link

Fluid Width prop to take only available space #165

Open yoelbassin opened 1 year ago

yoelbassin commented 1 year ago

Closed #164 since the source branch have changed. Here is the PR rebased from react-v18

palerdot commented 1 year ago

Thanks, I'm tracking this PR in this issue - https://github.com/palerdot/react-d3-speedometer/issues/166

palerdot commented 1 year ago

@yoelbassin This PR introduces a new prop valueTextBelowPos without being discussed. It would be better if this prop is discussed before making code changes. I'm not also not ok with the prop name valueTextBelowPos, which does not clearly indicate what this does exactly.

There is a whole lot to be done including updating documentation when a new prop is introduced - https://github.com/palerdot/react-d3-speedometer/issues/153

This prop change should be discussed including the name in the issue - https://github.com/palerdot/react-d3-speedometer/issues/166, before I can consider on next steps regarding this PR.