palewire / archiveis

A simple Python wrapper for the archive.is capturing service
https://archive.is
MIT License
188 stars 16 forks source link

proxy compatibility #6

Closed DPS0340 closed 6 years ago

DPS0340 commented 6 years ago

i edit the code a little. would you pull it? :D

palewire commented 6 years ago

I'm okay with this idea, but I think I'd prefer to add as little code as possible. I have an alternative idea I'm going to try real quick.

palewire commented 6 years ago

I just shipped a new version to PyPI that supports proxies. It's not as integrated as your work, but I think will accomplish the same task. I added a "proxies" kwarg to the capture function that will pass along a dictionary to the proxies kwarg on requests. Let me know if this will work for you.

DPS0340 commented 6 years ago

i'll check it. thanks for the help.

DPS0340 commented 6 years ago

tested it. your code shows me a better way!