search

palewire / cummings.ee

A collection of the work of Edward Estlin Cummings, as it enters the public domain.
https://cummings.ee
MIT License
54 stars 30 forks source link

Test fix for x-overflow bar (Fixes #133) #229

Open arky opened 1 year ago

arky commented 1 year ago

Fix for the extra scroll bar in Google Chrome.

Screenshot from 2022-12-12 13-02-41

palewire commented 1 year ago

Thanks for giving this a shot. My question: Will this change affect the overflow scrolling we want to force on the poem detail pages?

arky commented 1 year ago

@palewire the best solution for this is figure out which container element is causing the scrolling. It is bit tricky as this needs some elbow grease to figure this out.

arky commented 1 year ago

Thanks for giving this a shot. My question: Will this change affect the overflow scrolling we want to force on the poem detail pages?

@palewire Overflow scroll is not inherited https://www.w3.org/TR/css-overflow-3/#overflow-properties Do you have an example of detail page where overflow scrolling needs to be forced. I'll need to do some testing this in multiple browsers.

palewire commented 1 year ago

Sure https://cummings.ee/book/tulips-and-chimneys/poem/post-impressions-vi/

arky commented 1 year ago

Thanks @palewire After some additional testing, I have pushed an elegant fix by using overflow: auto; instead of overflow: scroll.

The main difference is that with auto setting browser will only display scroll bars when needed, when the content overflows.

When you set overflow: scroll the browser will always display a scroll bar but disables it (not interactive).

https://www.w3schools.com/css/css_overflow.asp

HTH