search

palewire / django-calaccess-campaign-browser

A Django app to refine, review and republish campaign finance data drawn from the California Secretary of State’s CAL-ACCESS database
http://django-calaccess-campaign-browser.californiacivicdata.org
MIT License
17 stars 12 forks source link

Fix for pagination controls (issue #69). #190

Closed myshkin closed 9 years ago

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 36.17% when pulling 148eb11cf598fbbdb80604246f05753670b4683f on myshkin:pagination-fix-69 into 83a3fca3de62c73e86dd4b12642f508365c13d86 on california-civic-data-coalition:master.

palewire commented 9 years ago

Thanks. Looks like a clear improvement to me. Seeing any other bugs with the pagination while you were in there?

myshkin commented 9 years ago

I didn't look too closely, but no. Given a sufficiently slow browser, though, all of the page controls (1 to paginator.num_pages) flash on the screen before being hidden...that's inherent to the jQuery Pagination plugin, I think.

palewire commented 9 years ago

My WiFi is slow at the moment and I noticed the same "flash" myself as all the assets loaded. I suspect you're right that just comes with the plugin but I'm open to ideas about how to avoid it. Or really anything else you thought about how to improve pagination.