pali / bmfdec

Decompile binary MOF file (BMF) from WMI buffer
https://www.spinics.net/lists/kernel/msg2524043.html
51 stars 17 forks source link

Fix IO handling #3

Closed Wer-Wolf closed 1 year ago

Wer-Wolf commented 1 year ago

This PR fixes the handling of file IO in bmfdec, which caused random errors whenever read() encountered a "short read". This usually happened with BMOF data larger than 4096 bytes. It also adds a gitignore file to ignore the executables.

pali commented 1 year ago

Thanks for pointing out. I have re-implemented reading input file, including support for command line arguments, and with that I switches from POSIX fd descriptor API to C FILE* API. I hope that this issue is fixed now in master branch. And about gitignore, I'm not a big fan of this usage.

Wer-Wolf commented 1 year ago

The issue has been solved, i checked. I will close this PR then. Thanks