palimadra / gmail-delay-send

Automatically exported from code.google.com/p/gmail-delay-send
5 stars 0 forks source link

time ignored when using "tomorrow, [anytime]" email sent at midnight #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.  Add " -- Tomorrow, 14:00" to subject line
2.  Mail will be sent at midnight
3.

What is the expected output? What do you see instead?

Expect mail to be sent the next day at 2pm.  Instead it is being sent today at 
midnight

What version of the product are you using? On what operating system?
latest, windows 7, chrome

Please provide any additional information below.

This interpretation of the time is confirmed by the test cell in the spreadsheet

Thanks!

Original issue reported on code.google.com by m...@prestile.com on 26 Jul 2012 at 9:39

GoogleCodeExporter commented 9 years ago
Over at the datejs wiki, a programmer posted some code to invoke datejs in a 
way that the "tomorrow 8am" format will give a good result.  Maybe 
gmail-delay-send could use this method to produce a better result.  Here is the 
link:

https://groups.google.com/forum/?fromgroups=#!topic/datejs/YUGsQplVZHI

Original comment by barry.t...@gmail.com on 21 Nov 2012 at 6:11

GoogleCodeExporter commented 9 years ago
Thanks for the pointer barry.troy!

Just starting to work on the next version of gmail-delay-send and will be sure 
to include this code snippit:

Replace 

g._start = _.process(_.set([ g.date, g.time, g.expression ], 
        g.generalDelimiter, g.whiteSpace), t.finish); 

with 

g._start = _.process(_.set([ g.date, g.time, g.expression, 
g.expression ], 
        g.generalDelimiter, g.whiteSpace), t.finish); 

It would most probably be more elegant to redefine the double 
g.expression with two more distinct parsers, but this quick solution 
did it for me. Hope it also helps someone else. 

Original comment by blairk...@gmail.com on 15 Feb 2013 at 3:10

GoogleCodeExporter commented 9 years ago
Also, removed the 'tomorrow, 5pm' example from the wiki to avoid future 
confusion.

Original comment by blairk...@gmail.com on 15 Feb 2013 at 3:11

GoogleCodeExporter commented 9 years ago
Issue 51 has been merged into this issue.

Original comment by blairk...@gmail.com on 15 Feb 2013 at 3:24

GoogleCodeExporter commented 9 years ago
Issue 53 has been merged into this issue.

Original comment by blairk...@gmail.com on 15 Feb 2013 at 3:24

GoogleCodeExporter commented 9 years ago
Tried making the change in datejs suggested above, but neither 'tomorrow, 10pm' 
or 'tomorrow 10pm' seem to work.

b/c this is a datejs issue, I'm going to mark as a WontFix. I would open a bug 
against datejs, but it appears that there isn't any active development on that 
project so might not make much of a difference unless you want to try to fix it 
yourself.

Thanks for checking out the project!

Original comment by blairk...@gmail.com on 18 May 2013 at 8:50