search

palinek / pvr.sledovanitv.cz

Kodi's sledovanitv.cz client addon
GNU General Public License v2.0
30 stars 14 forks source link

Implement PVR addon API v6.0.0 #29

Closed ksooo closed 5 years ago

ksooo commented 5 years ago

Initial Kodi Matrix Addon version, implements PVR addon API v6.0.0

Do not merge until https://github.com/xbmc/xbmc/pull/15953 was merged!

palinek commented 5 years ago

@ksooo you've created Matrix branch and now you're making PR against that branch. Is the Matrix new code name for the Kodi 19.* release? Should now the Matrix branch be the default one? (if yes, we can remove the master branch) Or is there some howto/wiki where I should look into and act accordingly?

ksooo commented 5 years ago

you've created Matrix branch and now you're making PR against that branch.

Is the Matrix new code name for the Kodi 19.* release?

Yes. => http://www.kodi.tv/article/kodi-19-gets-codename

Should now the Matrix branch be the default one? (if yes, we can remove the master branch)

Yes and yes.

Or is there some howto/wiki where I should look into and act accordingly?

No, not yet.

PVR Addon "Leia" branch -> Kodi "Leia" branch PVR Addon "Matrix" branch -> Kodi "master" branch PVR Addon "master" branch -> dead

We need to "shadow" the binary addon repo structure with the addon branch. Binary addon repo "master" would be ambigious.

Rechi commented 5 years ago

we can remove the master branch

Don't remove the master branch, it might be referenced somewhere for older Kodi versions. Just set the default branch to Matrix at https://github.com/palinek/pvr.sledovanitv.cz/settings/branches.

palinek commented 5 years ago

OK. Set the default branch to Matrix...and left the master intact.

palinek commented 5 years ago

Hm...why did you merge all the PVR PRs when the upstream Kodi PR isn't merged yet?

ksooo commented 5 years ago

Because I know what I'm doing. ;-) This is not the first time I'm syncing an incompatible API change.