search

palinek / pvr.sledovanitv.cz

Kodi's sledovanitv.cz client addon
GNU General Public License v2.0
30 stars 14 forks source link

fix windows uwp compile error #3

Closed Rechi closed 6 years ago

palinek commented 6 years ago

Should I only cherry-pick the a55981f (fix windows uwp compile error) ? Or will you update the PR as a whole?

Rechi commented 6 years ago

@palinek updated

palinek commented 6 years ago

Is this a well-known fix and I should merge it immediately or should I wait for appveyor to confirm the build?

Rechi commented 6 years ago

Tested this on my windows system, but didn't had access to it earlier today.

palinek commented 6 years ago

@Rechi thanks for all of the improvements and CI recipes. Is working CI a condition for merging my PR into kodi-pvr repo?

Update: sorry I meant PR into repo-binary-addons

Rechi commented 6 years ago

CI isn't a hard requirement, but it is set up for most binary addons.

I pinged our pvr guy to have a look at your addon.