search

paljs / prisma-tools

Prisma tools to help you generate CRUD system for GraphQL servers
https://paljs.com
MIT License
683 stars 54 forks source link

Changed options parameter on PrismaDelete to be optional #143

Closed carlosfiori closed 3 years ago

carlosfiori commented 3 years ago

Today the options parameter of constructor PrismaDelete is required, but on my opinion should be optional, this PR change the parameter to optional to avoid pass empty objects.

Before PR: image image

After PR: image

carlosfiori commented 3 years ago

@AhmedElywa

AhmedElywa commented 3 years ago

Sorry I was busy all day. I am working on another stuff in this file. So I will cancel this pull request because I will get a merge conflict. I already added this fix to my code. You will get this fix in the next release.

AhmedElywa commented 3 years ago

Thanks, @carlosfiori. For this pull request, I fixed this issue in my last release.